Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Request] Adds Ball gown and mini crown to loadout #3621

Closed
wants to merge 11 commits into from

Conversation

Shoddd
Copy link
Collaborator

@Shoddd Shoddd commented Sep 30, 2024

About The Pull Request

Title

Why It's Good For The Game

More ways for people to dress their spessmen up is nice, its not very similar to any other items in the loadout menu I think its unique enough to not become bloat.

Changelog

🆑
add: Adds ball gown and mini crown to loadout menu
add: Mini crown, in loadout and autodrobe
/:cl:

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull request process. -->

## About The Pull Request
fixes Monkestation#3606
<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->

## Why It's Good For The Game
Space helmet, space worthy, airtight, not internal worthy??
<!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. -->

:cl:
fix: frontier modsuit helmet now airtight
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
@Shoddd Shoddd marked this pull request as draft September 30, 2024 04:37
@Shoddd
Copy link
Collaborator Author

Shoddd commented Sep 30, 2024

bleh left change from other PR no idea how got in

@Shoddd Shoddd marked this pull request as ready for review September 30, 2024 04:54
@Shoddd
Copy link
Collaborator Author

Shoddd commented Oct 1, 2024

re-opening tomorrow with more stuff

@Shoddd Shoddd closed this Oct 1, 2024
@Shoddd Shoddd reopened this Oct 3, 2024
@Shoddd Shoddd changed the title [Code Request] Adds Ball gown to loadout [Code Request] Adds Ball gown and mini crown to loadout Oct 3, 2024
@Shoddd
Copy link
Collaborator Author

Shoddd commented Oct 15, 2024

wtf did I click

@Shoddd Shoddd reopened this Oct 15, 2024
@Shoddd Shoddd marked this pull request as draft October 15, 2024 20:27
@Shoddd
Copy link
Collaborator Author

Shoddd commented Oct 15, 2024

screw this Im just gonna make a fresh branch.,

@Shoddd Shoddd closed this Oct 15, 2024
@Shoddd Shoddd deleted the ballsgown branch October 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant